datapath: avoid memory corruption in queue_userspace_packet()
authorAndy Zhou <azhou@nicira.com>
Thu, 12 Jun 2014 20:19:25 +0000 (13:19 -0700)
committerAndy Zhou <azhou@nicira.com>
Fri, 13 Jun 2014 00:06:14 +0000 (17:06 -0700)
commit33d15fbdcded3bc34719abbf647a60a2d1357917
treee5a4eebd480ea7a4409b4de0af2d0280b5daeb53
parent5b80ff05dbe05cf8a5f9e5bded5494958dc53ef1
datapath:  avoid memory corruption in queue_userspace_packet()

In queue_userspace_packet(), the ovs_nla_put_flow return value is
not checked. This is fine as long as key_attr_size() returns the
correct value. In case it does not, the current code may corrupt buffer
memory. Add a run time assertion catch this case to avoid silent
failure.

Reported-by: Ben Pfaff <blp@nicira.com>
Signed-off-by: Andy Zhou <azhou@nicira.com>
Acked-by: Pravin B Shelar <pshelar@nicira.com>
datapath/datapath.c