ofproto-dpif-xlate: More robust wildcarding for select group.
authorJarno Rajahalme <jrajahalme@nicira.com>
Thu, 19 Mar 2015 22:39:48 +0000 (15:39 -0700)
committerJarno Rajahalme <jrajahalme@nicira.com>
Tue, 24 Mar 2015 18:22:26 +0000 (11:22 -0700)
commit80e3509d72acecc44d4661f0da5f50a716e23e18
treea63387515c43d0d2321b48fe1c32c5d24f9e900b
parent5b09e56908a1b1e79d056e7be8e8a97783b1570d
ofproto-dpif-xlate: More robust wildcarding for select group.

The flow key should be the same regardless of whether a live bucket is
found or not, as it would be confusing that the flow key would be
different (different mask bits) after the last group bucket goes dead.

In general, the megaflow algorithm expects the mask bits be set as
soon as we read the header bits, regardless of what happens
afterwards.

Also, use flow_mask_hash_fields() instead of individually setting mask
fields. This immediately brings in IPv6 support, and helps keeping
masks in sync with potential algorithm changes to flow hashing
functions.

Found by inspection.

Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
ofproto/ofproto-dpif-xlate.c