datapath: Initialize tunnel_key pad member.
authorJesse Gross <jesse@nicira.com>
Mon, 31 Dec 2012 20:28:41 +0000 (12:28 -0800)
committerJesse Gross <jesse@nicira.com>
Mon, 31 Dec 2012 21:02:37 +0000 (13:02 -0800)
commit968b25dc15d34373e6f98f8fe6aa8d4dc1356524
treefbced1c2c6e65aa900a504d2bb5ecd3a3655ad5d
parent91184c191c2a7d931d51d21cfccd9357ade07457
datapath: Initialize tunnel_key pad member.

When a packet is received on a tunnel the pad member is currently
left uninitialized.  This didn't previously cause problems because
userspace didn't interprete the IPV4_TUNNEL attribute and blindly
copied back the uninitialized data.  However, now that userspace
knows how to serialize this attribute it was zeroing it out, which
prevented flows that had been previously installed from being
deleted.  In addition to zeroing out the padding on packet reception,
it also does the same thing on flow setup since we should be ignoring
the value.

Reported-by: Anand Krishnamurthy <krishnamurt4@wisc.edu>
Reported-by: Saul St. John <sstjohn@cs.wisc.edu>
Signed-off-by: Jesse Gross <jesse@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
Conflicts:

datapath/flow.c
datapath/flow.c
datapath/tunnel.h