stream-tcp: Call setsockopt TCP_NODELAY after TCP is connected.
authorGurucharan Shetty <gshetty@nicira.com>
Wed, 22 Oct 2014 22:35:18 +0000 (15:35 -0700)
committerGurucharan Shetty <gshetty@nicira.com>
Thu, 23 Oct 2014 18:07:32 +0000 (11:07 -0700)
commitb7cefbf7e52eb0262adb8447409d6ee52eb68a59
treeabb2f004882e47ffebf969ddb1870972d4bcde3a
parent0e55eddc30506f269412becae7254647630c4140
stream-tcp: Call setsockopt TCP_NODELAY after TCP is connected.

On Windows platform, TCP_NODELAY can only be set when TCP is established.
(This is an observed behavior and not written in any MSDN documentation.)
The current code does not create any problems while running unit tests
(because connections get established immediately) but is reportedly
observed while connecting to a different machine.

commit 8b76839(Move setsockopt TCP_NODELAY to when TCP is connected.)
made changes to call setsockopt with TCP_NODELAY after TCP is connected
only in lib/stream-ssl.c. We need the same change for stream-tcp too and
this commit does that.

Currently, a failure of setting TCP_NODELAY results in reporting
the error and then closing the socket. This commit changes that
behavior such that an error is reported if setting TCP_NODELAY
fails, but the connection itself is not torn down.

Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
lib/socket-util.c
lib/socket-util.h
lib/stream-fd.c
lib/stream-fd.h
lib/stream-ssl.c
lib/stream-tcp.c
lib/stream-unix.c