datapath: 16bit inner_network_header field in struct ovs_gso_cb
authorSimon Horman <horms@verge.net.au>
Tue, 20 May 2014 23:31:47 +0000 (08:31 +0900)
committerJesse Gross <jesse@nicira.com>
Wed, 21 May 2014 00:12:35 +0000 (17:12 -0700)
commite262505ce4b908307441478a9b65e1bb22760e0c
treed3ceec42d46e8148b6942da69a7abba49221e0a8
parent0e6661604066cabc41d6a43ac7761eefab746a53
datapath: 16bit inner_network_header field in struct ovs_gso_cb

The motivation for this is to create a 16bit hole in struct ovs_gso_cb
which may be used for the inner_protocol field which is needed
for the proposed implementation of compatibility for MPLS GSO segmentation.

This should be safe as inner_network_header is now an offset to
the inner_mac_header rather than skb->head.

As pointed out by Thomas Graf simply making both inner offsets 16bis is not
safe as there have been cases of overflow with "with collapsed TCP frames
on IB when the headroom grew beyond 64K. See commit 50bceae9bd ``tcp:
Reallocate headroom if it would overflow csum_start'' for additional
details."

This patch is based on suggestions by Thomas Graf and Jesse Gross.

Cc: Thomas Graf <tgraf@suug.ch>
Cc: Jesse Gross <jesse@nicira.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Jesse Gross <jesse@nicira.com>
datapath/linux/compat/gso.h