recirculation: Do not drop packet when there is no match from
authorAlex Wang <alexw@nicira.com>
Sat, 13 Dec 2014 04:51:58 +0000 (20:51 -0800)
committerAlex Wang <alexw@nicira.com>
Sat, 13 Dec 2014 05:03:57 +0000 (21:03 -0800)
commite8b2f7930717118634053e90495ac3b82bf141bd
tree1ddee1066c5940ef9478bda6dae514aa79f024a6
parent07391d1b3f0a6ca45b9d39924f44f475e416a423
recirculation: Do not drop packet when there is no match from
internal table.

In current recirculation implementation, the flow misses (with
'recirc_id' set) are always looked up on the receiving bridge's
internal flow table.  However, the bond port may actually reside
on another bridge which gets connected to the receiving bridge
via patch port.  Since the recirculation rules are pushed to the
other bridge's internal table, the flow lookup on the receiving
bridge will match nothing but the drop rule, causing unexpected
packet drops.

This commit fixes the above bug via keeping lookup the misses
(with 'recirc_id' set) in default table (table 0) and processing
it until reaching the bridge that owns the bond port.  Then,
the misses can hit the post recirculation flows as expected.

VMware-BZ: 1362178

Reported-by: Ansis Atteka <aatteka@nicira.com>
Signed-off-by: Alex Wang <alexw@nicira.com>
Acked-by: Andy Zhou <azhou@nicira.com>
ofproto/ofproto-dpif-xlate.c
ofproto/ofproto-dpif.c
ofproto/ofproto-dpif.h