From: William Tu Date: Thu, 11 Feb 2016 17:45:07 +0000 (-0800) Subject: expr: Fix memory leak reported by valgrind. X-Git-Url: http://git.cascardo.eti.br/?p=cascardo%2Fovs.git;a=commitdiff_plain;h=1cad4a759cbeb201f16052f866737ad64243998a expr: Fix memory leak reported by valgrind. Testcase 1728: ovn -- 5-term mixed expression normalization Call stack: sset_add__ (sset.c:53) crush_and_string (expr.c:1725) crush_cmps (expr.c:1998) expr_sort (expr.c:2050) expr_normalize_and (expr.c:2085) Signed-off-by: William Tu Signed-off-by: Daniele Di Proietto Co-authored-by: Daniele Di Proietto Signed-off-by: Russell Bryant --- diff --git a/ovn/lib/expr.c b/ovn/lib/expr.c index f30500e89..316d55701 100644 --- a/ovn/lib/expr.c +++ b/ovn/lib/expr.c @@ -1749,6 +1749,7 @@ crush_and_string(struct expr *expr, const struct expr_symbol *symbol) sub->cmp.string = xstrdup(string); list_push_back(&expr->andor, &sub->node); } + sset_destroy(&result); return expr_fix(expr); }