From: Jarno Rajahalme <jrajahalme@nicira.com>
Date: Tue, 17 Dec 2013 23:54:30 +0000 (-0800)
Subject: Remove unnecessary memset().
X-Git-Url: http://git.cascardo.eti.br/?p=cascardo%2Fovs.git;a=commitdiff_plain;h=877c9270fb28ae61b0de4b3dba74ef33adc4d7be

Remove unnecessary memset().

We already set all the fields of the upcall, so memsetting right before
is unnecessary.

Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
---

diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
index ea2300a81..f64e55b0d 100644
--- a/lib/dpif-linux.c
+++ b/lib/dpif-linux.c
@@ -1460,7 +1460,7 @@ parse_odp_packet(struct ofpbuf *buf, struct dpif_upcall *upcall,
         return EINVAL;
     }
 
-    memset(upcall, 0, sizeof *upcall);
+    /* (Re)set ALL fields of '*upcall' on successful return. */
     upcall->type = type;
     upcall->key = CONST_CAST(struct nlattr *,
                              nl_attr_get(a[OVS_PACKET_ATTR_KEY]));