From 31a6d02983c60416ffe6e38adf0fff0326fdf677 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Fri, 5 Feb 2016 15:30:24 -0800 Subject: [PATCH] ofproto-macros: Fix definition of add_of_ports. This definition just didn't work, and caused lots of tests to inadvertently be effectively skipped. Fixes: ca5792f0d80ffd (tests: Change ADD_OF_PORTS from macro to shell function.) Signed-off-by: Ben Pfaff Acked-by: Jarno Rajahalme Signed-off-by: Ben Pfaff --- tests/ofproto-macros.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 354a38407..c6c33215e 100644 --- a/tests/ofproto-macros.at +++ b/tests/ofproto-macros.at @@ -338,8 +338,8 @@ check_logs () { add_of_ports () { local args local br=$1; shift - for $pnum; do - AS_VAR_APPEND([args], [" -- $br p$pnum -- set Interface p$pnum type=dummy ofport_request=$pnum"]) + for pnum; do + AS_VAR_APPEND([args], [" -- add-port $br p$pnum -- set Interface p$pnum type=dummy ofport_request=$pnum"]) done ovs-vsctl $args } -- 2.20.1