From 885648d972f3d85c55cfb89e32773f1460bfe7ea Mon Sep 17 00:00:00 2001 From: Sorin Vinturis Date: Wed, 24 Jun 2015 10:56:55 +0000 Subject: [PATCH] datapath-windows: Wrong cleanup of newly created multiple NBLs Bug found in OvsPartialCopyToMultipleNBLs function in the cleanup part of the code. Before completing the current NBL (newNbl) the NEXT link for the following NBL (firstNbl) was broken, instead of the current one (newNbl). Signed-off-by: Sorin Vinturis Reported-by: Sorin Vinturis Reported-at: https://github.com/openvswitch/ovs-issues/issues/87 Acked-by: Nithin Raju Signed-off-by: Ben Pfaff --- datapath-windows/ovsext/BufferMgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/BufferMgmt.c b/datapath-windows/ovsext/BufferMgmt.c index 5adbb2518..83d6cdee3 100644 --- a/datapath-windows/ovsext/BufferMgmt.c +++ b/datapath-windows/ovsext/BufferMgmt.c @@ -881,7 +881,7 @@ cleanup: newNbl = firstNbl; while (newNbl) { firstNbl = NET_BUFFER_LIST_NEXT_NBL(newNbl); - NET_BUFFER_LIST_NEXT_NBL(firstNbl) = NULL; + NET_BUFFER_LIST_NEXT_NBL(newNbl) = NULL; OvsCompleteNBL(context, newNbl, TRUE); newNbl = firstNbl; } -- 2.20.1