From 93e83e8b8a2735ed1c515e9dddc1d45927ebf754 Mon Sep 17 00:00:00 2001 From: Mark Kavanagh Date: Tue, 10 Feb 2015 14:46:22 +0000 Subject: [PATCH] CONTRIBUTING.md: Strengthen testing recommendataions. Patches that modify existing code can break expected behaviour. Flag this by testing the patch with 'make check' prior to submission. Furthermore, it is not sufficient to only test patches that add files using 'make distcheck'; the compile flags for this target could change the definition of some functions (ovs_assert, for example), altering the outcome of some unit tests. Rather, it is preferable to use a combination of 'make distcheck' with 'make check' to cover all bases. Signed-off-by: Mark Kavanagh Signed-off-by: Ben Pfaff --- CONTRIBUTING.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 23c5410a1..d48924f26 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -27,7 +27,10 @@ In particular: Testing is also important: - - A patch that adds or deletes files should be tested with + - A patch that modifies existing code should be tested with + `make check` before submission. + + - A patch that adds or deletes files should also be tested with `make distcheck` before submission. - A patch that modifies Linux kernel code should be at least -- 2.20.1