From c5ccf99b91d531d35bdb5e9e1b5fb5312114285a Mon Sep 17 00:00:00 2001 From: Huanle Han Date: Fri, 5 Feb 2016 15:43:25 -0800 Subject: [PATCH] ofproto-dpif-mirror: Fix bug that flag "need_revalidate" is never reset. Flag "need_revalidate" on mbridge is set to true when an ofbundle destroy. And it's never reset. It causes the backer revalidate and the mac learning flush every time 'ofproto_run' is called. Signed-off-by: Huanle Han Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-mirror.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif-mirror.c b/ofproto/ofproto-dpif-mirror.c index f3ff5782c..6f8079a3c 100644 --- a/ofproto/ofproto-dpif-mirror.c +++ b/ofproto/ofproto-dpif-mirror.c @@ -131,11 +131,13 @@ mbridge_has_mirrors(struct mbridge *mbridge) } /* Returns true if configurations changes in 'mbridge''s mirrors require - * revalidation. */ + * revalidation, and resets the revalidation flag to false. */ bool mbridge_need_revalidate(struct mbridge *mbridge) { - return mbridge->need_revalidate; + bool need_revalidate = mbridge->need_revalidate; + mbridge->need_revalidate = false; + return need_revalidate; } void -- 2.20.1