From f58df86078af10aba97484671db8739769df29f1 Mon Sep 17 00:00:00 2001 From: Ben Pfaff Date: Fri, 13 Mar 2015 13:02:52 -0700 Subject: [PATCH] FAQ.md: Add a few more details on how to support a new field. Signed-off-by: Ben Pfaff Acked-by: Thomas Graf --- FAQ.md | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/FAQ.md b/FAQ.md index b2fc646ee..b112dfb41 100644 --- a/FAQ.md +++ b/FAQ.md @@ -1748,11 +1748,25 @@ A: Add your new message to "enum ofpraw" and "enum ofptype" in A: Add new members for your field to "struct flow" in lib/flow.h, and add new enumerations for your new field to "enum mf_field_id" in - lib/meta-flow.h, following the existing pattern. Then recompile - and fix all of the new warnings, implementing new functionality for - the new field or header as needed. (If you configure with - --enable-Werror, as described in [INSTALL.md], then it is - impossible to miss any warnings.) + lib/meta-flow.h, following the existing pattern. Also, add support + to miniflow_extract() in lib/flow.c for extracting your new field + from a packet into struct miniflow. Then recompile and fix all of + the new warnings, implementing new functionality for the new field + or header as needed. (If you configure with --enable-Werror, as + described in [INSTALL.md], then it is impossible to miss any + warnings.) + + If you want kernel datapath support for your new field, you also + need to modify the kernel module for the operating systems you are + interested in. This isn't mandatory, since fields understood only + by userspace work too (with a performance penalty), so it's + reasonable to start development without it. If you implement + kernel module support for Linux, then the Linux kernel "netdev" + mailing list is the place to submit that support first; please read + up on the Linux kernel development process separately. The Windows + datapath kernel module support, on the other hand, is maintained + within the OVS tree, so patches for that can go directly to + ovs-dev. ### Q: How do I add support for a new OpenFlow action? -- 2.20.1