projects
/
cascardo
/
ovs.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e80323d
)
ofp-util: Fix null pointer dereference in ofputil_pull_buckets().
author
Ben Pfaff
<blp@nicira.com>
Mon, 14 Jul 2014 21:33:01 +0000
(14:33 -0700)
committer
Ben Pfaff
<blp@nicira.com>
Tue, 15 Jul 2014 16:43:59 +0000
(09:43 -0700)
Found by clang-analyzer.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
lib/ofp-util.c
patch
|
blob
|
history
diff --git
a/lib/ofp-util.c
b/lib/ofp-util.c
index
09e4438
..
b303653
100644
(file)
--- a/
lib/ofp-util.c
+++ b/
lib/ofp-util.c
@@
-6978,6
+6978,7
@@
ofputil_pull_buckets(struct ofpbuf *msg, size_t buckets_length,
if (!ob) {
VLOG_WARN_RL(&bad_ofmsg_rl, "buckets end with %"PRIuSIZE" leftover bytes",
buckets_length);
+ return OFPERR_OFPGMFC_BAD_BUCKET;
}
ob_len = ntohs(ob->len);