rxrpc: Fix checking of error from ip6_route_output()
authorDavid Howells <dhowells@redhat.com>
Thu, 13 Oct 2016 07:43:17 +0000 (08:43 +0100)
committerDavid Howells <dhowells@redhat.com>
Thu, 13 Oct 2016 07:43:17 +0000 (08:43 +0100)
ip6_route_output() doesn't return a negative error when it fails, rather
the ->error field of the returned dst_entry struct needs to be checked.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 75b54cb57ca3 ("rxrpc: Add IPv6 support")
Signed-off-by: David Howells <dhowells@redhat.com>
net/rxrpc/peer_object.c

index 941b724..862eea6 100644 (file)
@@ -193,8 +193,8 @@ static void rxrpc_assess_MTU_size(struct rxrpc_peer *peer)
                fl6->fl6_dport = htons(7001);
                fl6->fl6_sport = htons(7000);
                dst = ip6_route_output(&init_net, NULL, fl6);
-               if (IS_ERR(dst)) {
-                       _leave(" [route err %ld]", PTR_ERR(dst));
+               if (dst->error) {
+                       _leave(" [route err %d]", dst->error);
                        return;
                }
                break;