ATM-nicstar: Refactor a dev_alloc_skb() call in dequeue_rx()

The script "checkpatch.pl" can point out that assignments should usually
not be performed within condition checks.
Thus move an assignment for a local variable to a separate statement
in this function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c
index 04f5781..c7296b5 100644 (file)
--- a/drivers/atm/nicstar.c
+++ b/drivers/atm/nicstar.c
@@ -2023,7 +2023,8 @@ static void dequeue_rx(ns_dev * card, ns_rsqe * rsqe)
 
                cell = skb->data;
                for (i = ns_rsqe_cellcount(rsqe); i; i--) {
-                       if ((sb = dev_alloc_skb(NS_SMSKBSIZE)) == NULL) {
+                       sb = dev_alloc_skb(NS_SMSKBSIZE);
+                       if (!sb) {
                                printk
                                    ("nicstar%d: Can't allocate buffers for aal0.\n",
                                     card->index);