blackfin: fix put_user sparse errors
authorMichael S. Tsirkin <mst@redhat.com>
Tue, 6 Jan 2015 12:37:22 +0000 (14:37 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 13 Jan 2015 13:23:32 +0000 (15:23 +0200)
virtio wants to write bitwise types to userspace using put_user.
At the moment this triggers sparse errors, since the value is passed
through an integer.

For example:

__le32 __user *p;
__le32 x;
put_user(x, p);

is safe, but currently triggers a sparse warning.

Fix that up using __force.

Note: this does not suppress any useful sparse checks since caller
assigns x to typeof(*p), which in turn forces all the necessary type
checks.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
arch/blackfin/include/asm/uaccess.h

index 2dcc930..4bf968c 100644 (file)
@@ -89,10 +89,10 @@ struct exception_table_entry {
                        break;                                  \
                case 8: {                                       \
                        long _xl, _xh;                          \
-                       _xl = ((long *)&_x)[0];                 \
-                       _xh = ((long *)&_x)[1];                 \
-                       __put_user_asm(_xl, ((long __user *)_p)+0, );   \
-                       __put_user_asm(_xh, ((long __user *)_p)+1, );   \
+                       _xl = ((__force long *)&_x)[0];         \
+                       _xh = ((__force long *)&_x)[1];         \
+                       __put_user_asm(_xl, ((__force long __user *)_p)+0, );\
+                       __put_user_asm(_xh, ((__force long __user *)_p)+1, );\
                } break;                                        \
                default:                                        \
                        _err = __put_user_bad();                \