ext4: correct endianness conversion in __xattr_check_inode()
authorEric Biggers <ebiggers@google.com>
Sat, 15 Oct 2016 13:39:31 +0000 (09:39 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 15 Oct 2016 13:39:31 +0000 (09:39 -0400)
It should be cpu_to_le32(), not le32_to_cpu().  No change in behavior.

Found with sparse, and this was the only endianness warning in fs/ext4/.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
fs/ext4/xattr.c

index c15d633..e90c5cd 100644 (file)
@@ -241,7 +241,7 @@ __xattr_check_inode(struct inode *inode, struct ext4_xattr_ibody_header *header,
        int error = -EFSCORRUPTED;
 
        if (((void *) header >= end) ||
-           (header->h_magic != le32_to_cpu(EXT4_XATTR_MAGIC)))
+           (header->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC)))
                goto errout;
        error = ext4_xattr_check_names(entry, end, entry);
 errout: