CHROMIUM: v4l2-m2m: use CAPTURE queue lock
authorJohn Sheu <sheu@chromium.org>
Tue, 11 Dec 2012 06:33:50 +0000 (22:33 -0800)
committerChromeBot <chrome-bot@google.com>
Fri, 11 Jan 2013 04:13:36 +0000 (20:13 -0800)
In v4l2_m2m_try_schedule(), use the CAPTURE queue lock when accessing
the CAPTURE queue, instead of relying on just holding the OUTPUT queue
lock.

Signed-off-by: John Sheu <sheu@google.com>
BUG=chrome-os-partner:10057
BUG=chrome-os-partner:14521
TEST=local build, run on exynos

Change-Id: I3f90d703dd051201f338d8e5758d3036150c78a2
Reviewed-on: https://gerrit.chromium.org/gerrit/39537
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Tested-by: John Sheu <sheu@chromium.org>
Commit-Queue: John Sheu <sheu@chromium.org>

drivers/media/video/v4l2-mem2mem.c

index d64811c..8cad5ac 100644 (file)
@@ -227,12 +227,15 @@ static void v4l2_m2m_try_schedule(struct v4l2_m2m_ctx *m2m_ctx)
                dprintk("No input buffers available\n");
                return;
        }
+       spin_lock_irqsave(&m2m_ctx->cap_q_ctx.rdy_spinlock, flags);
        if (list_empty(&m2m_ctx->cap_q_ctx.rdy_queue)) {
+               spin_unlock_irqrestore(&m2m_ctx->cap_q_ctx.rdy_spinlock, flags);
                spin_unlock_irqrestore(&m2m_ctx->out_q_ctx.rdy_spinlock, flags);
                spin_unlock_irqrestore(&m2m_dev->job_spinlock, flags_job);
                dprintk("No output buffers available\n");
                return;
        }
+       spin_unlock_irqrestore(&m2m_ctx->cap_q_ctx.rdy_spinlock, flags);
        spin_unlock_irqrestore(&m2m_ctx->out_q_ctx.rdy_spinlock, flags);
 
        if (m2m_dev->m2m_ops->job_ready