CHROMIUM: regulator: s5m8767: properly disable regulators
authorVincent Palatin <vpalatin@chromium.org>
Tue, 19 Feb 2013 21:31:23 +0000 (13:31 -0800)
committerChromeBot <chrome-bot@google.com>
Tue, 19 Feb 2013 22:59:13 +0000 (14:59 -0800)
Whatever the default operating mode of a regulator is, we want to ensure
that we are actually putting 0 in the mode to disable it.

Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
BUG=chrome-os-partner:17866
TEST=manual

Change-Id: Ic019c92a72b3a97b6ea06657b4f57774337519de
Reviewed-on: https://gerrit.chromium.org/gerrit/43531
Reviewed-by: Todd Broch <tbroch@chromium.org>
Commit-Queue: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
drivers/regulator/s5m8767.c

index 3c3ad8d..3326082 100644 (file)
@@ -241,7 +241,7 @@ static int s5m8767_reg_disable(struct regulator_dev *rdev)
        if (ret)
                return ret;
 
-       return s5m_reg_update(s5m8767->iodev, reg, ~pattern, mask);
+       return s5m_reg_update(s5m8767->iodev, reg, ~mask, mask);
 }
 
 static int s5m8767_get_voltage_register(struct regulator_dev *rdev, int *_reg)