UPSTREAM: staging: gdm72xx: use kzalloc to allocate usb_tx structure
authorDevendra Naga <devendra.aaru@gmail.com>
Sat, 25 Aug 2012 21:22:35 +0000 (02:52 +0530)
committerGerrit <chrome-bot@google.com>
Fri, 7 Sep 2012 04:56:27 +0000 (21:56 -0700)
the code under alloc_tx_struct does the allocation of usb_tx structure
using kmalloc, and memsets the allocated pointer, instead we can
directly use kzalloc so that the allocated memory is set with
zeros

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 07ad99c9e32173852997523eb920950902563941)

Change-Id: I623dd5512b116924c7a5fbaefbbd26296a14cdab
Reviewed-on: https://gerrit.chromium.org/gerrit/32489
Reviewed-by: Olof Johansson <olofj@chromium.org>
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
drivers/staging/gdm72xx/gdm_sdio.c
drivers/staging/gdm72xx/gdm_usb.c

index 3e43c01..ec64d94 100644 (file)
@@ -62,12 +62,10 @@ static struct sdio_tx *alloc_tx_struct(struct tx_cxt *tx)
 {
        struct sdio_tx *t = NULL;
 
-       t = kmalloc(sizeof(*t), GFP_ATOMIC);
+       t = kzalloc(sizeof(*t), GFP_ATOMIC);
        if (t == NULL)
                goto out;
 
-       memset(t, 0, sizeof(*t));
-
        t->buf = kmalloc(TX_BUF_SIZE, GFP_ATOMIC);
        if (t->buf == NULL)
                goto out;
index d48d49c..c7a22fa 100644 (file)
@@ -75,12 +75,10 @@ static struct usb_tx *alloc_tx_struct(struct tx_cxt *tx)
 {
        struct usb_tx *t = NULL;
 
-       t = kmalloc(sizeof(*t), GFP_ATOMIC);
+       t = kzalloc(sizeof(*t), GFP_ATOMIC);
        if (t == NULL)
                goto out;
 
-       memset(t, 0, sizeof(*t));
-
        t->urb = usb_alloc_urb(0, GFP_ATOMIC);
        t->buf = kmalloc(TX_BUF_SIZE, GFP_ATOMIC);
        if (t->urb == NULL || t->buf == NULL)