UPSTREAM: staging/gdm72xx: use kzalloc for phydev and sdev
authorDevendra Naga <devendra.aaru@gmail.com>
Thu, 12 Jul 2012 06:13:37 +0000 (11:58 +0545)
committerGerrit <chrome-bot@google.com>
Tue, 7 Aug 2012 19:05:28 +0000 (12:05 -0700)
in sdio probe function we are doing kmalloc which can be done using kzalloc.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit c2a1793d1b2dedd3dfc33af00c6b1d4f050c040c)

Change-Id: I1cb958de85e1b249ec56af55cc05e9729d9e9388
Signed-off-by: Ben Chan <benchan@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/28219
Reviewed-by: Olof Johansson <olofj@chromium.org>
drivers/staging/gdm72xx/gdm_sdio.c

index 5e19b09..3e43c01 100644 (file)
@@ -664,20 +664,17 @@ static int sdio_wimax_probe(struct sdio_func *func,
        if (ret)
                return ret;
 
-       phy_dev = kmalloc(sizeof(*phy_dev), GFP_KERNEL);
+       phy_dev = kzalloc(sizeof(*phy_dev), GFP_KERNEL);
        if (phy_dev == NULL) {
                ret = -ENOMEM;
                goto out;
        }
-       sdev = kmalloc(sizeof(*sdev), GFP_KERNEL);
+       sdev = kzalloc(sizeof(*sdev), GFP_KERNEL);
        if (sdev == NULL) {
                ret = -ENOMEM;
                goto out;
        }
 
-       memset(phy_dev, 0, sizeof(*phy_dev));
-       memset(sdev, 0, sizeof(*sdev));
-
        phy_dev->priv_dev = (void *)sdev;
        phy_dev->send_func = gdm_sdio_send;
        phy_dev->rcv_func = gdm_sdio_receive;