clk: ti: consider the fact that of_clk_get() might return an error
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Thu, 18 Sep 2014 14:33:27 +0000 (16:33 +0200)
committerTero Kristo <t-kristo@ti.com>
Mon, 29 Sep 2014 08:51:13 +0000 (11:51 +0300)
I "forgot" to update the dtb and the kernel crashed:
|Unable to handle kernel NULL pointer dereference at virtual address 0000002e
|PC is at __clk_get_flags+0x4/0xc
|LR is at ti_dt_clockdomains_setup+0x70/0xe8

because I did not have the clock nodes. of_clk_get() returns an error
pointer which is not checked here.

Acked-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
drivers/clk/ti/clockdomain.c

index f1e0038..b4c5fac 100644 (file)
@@ -36,6 +36,11 @@ static void __init of_ti_clockdomain_setup(struct device_node *node)
 
        for (i = 0; i < num_clks; i++) {
                clk = of_clk_get(node, i);
+               if (IS_ERR(clk)) {
+                       pr_err("%s: Failed get %s' clock nr %d (%ld)\n",
+                              __func__, node->full_name, i, PTR_ERR(clk));
+                       continue;
+               }
                if (__clk_get_flags(clk) & CLK_IS_BASIC) {
                        pr_warn("can't setup clkdm for basic clk %s\n",
                                __clk_get_name(clk));