CHROMIUM: TEMPORARY: instrumentation for crosbug.com/p/17609
authorLuigi Semenzato <semenzato@chromium.org>
Fri, 22 Feb 2013 22:51:39 +0000 (14:51 -0800)
committerChromeBot <chrome-bot@google.com>
Wed, 27 Feb 2013 01:19:09 +0000 (17:19 -0800)
We have a hard time reproducing crosbug.com/p/17609.  It seems
to be correlated with a reset of the device.  We don't understand
why the reset happens and we're hoping that a stack trace will
give us some information.

From the logs we've seen, this doesn't happen very often, so
chances of spewing are low.  We get Link feedback reports with
this error almost daily.

BUG=chrome-os-partner:17609
TEST=not tested, or, rather, YOU test it
BRANCH=none

Signed-off-by: Luigi Semenzato <semenzato@chromium.org>
Change-Id: If24b4f2490919905d79cdf4e5b8b159cbe8aee6c
Reviewed-on: https://gerrit.chromium.org/gerrit/43832
Tested-by: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>
Commit-Queue: Luigi Semenzato <semenzato@chromium.org>

drivers/usb/core/hub.c

index 572769b..645c7a1 100644 (file)
@@ -3019,11 +3019,13 @@ hub_port_init (struct usb_hub *hub, struct usb_device *udev, int port1,
        else
                speed = usb_speed_string(udev->speed);
 
-       if (udev->speed != USB_SPEED_SUPER)
+       if (udev->speed != USB_SPEED_SUPER) {
                dev_info(&udev->dev,
                                "%s %s USB device number %d using %s\n",
                                (udev->config) ? "reset" : "new", speed,
                                devnum, udev->bus->controller->driver->name);
+               WARN_ON(udev->config); /* for crosbug.com/p/17609 */
+       }
 
        /* Set up TT records, if needed  */
        if (hdev->tt) {