arm: exynos: Don't print out warning about negative ASV group
authorDoug Anderson <dianders@chromium.org>
Tue, 2 Apr 2013 16:21:05 +0000 (09:21 -0700)
committerChromeBot <chrome-bot@google.com>
Thu, 4 Apr 2013 16:51:45 +0000 (09:51 -0700)
We have seen CPUs that end up with a calculated ASV group of -1.
According to Samsung these should be assigned group 0 and are no
problem, so we shouldn't warn about them.  We'll also stop warning
about other negative ASV groups.  If we need to find out the
calculated ASV group we can use the "EXYNOS5250: ORIG: %d MOD: %d
RESULT: %d" message and just to the math ourselves (ORIG-MOD).

BUG=chrome-os-partner:18505
TEST=Boot up a device with ASV group -1 and see the warning go away.

Change-Id: I7c20445b1fb5afc233614faace5f387e5c182a03
Signed-off-by: Doug Anderson <dianders@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/47126
Reviewed-by: Olof Johansson <olofj@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
arch/arm/mach-exynos/asv-5250.c

index 2f1e935..8ffbbfd 100644 (file)
@@ -457,10 +457,10 @@ static int exynos5250_asv_init(void)
                exynos_orig_sp = (chip_id >> ORIG_SG_OFFSET) & ORIG_SG_MASK;
                exynos_mod_sp = (chip_id >> MOD_SG_OFFSET) & MOD_SG_MASK;
                exynos_cal_asv = exynos_orig_sp - exynos_mod_sp;
-               if (exynos_cal_asv < 0) {
-                       pr_warn("Illegal ASV group: %d\n", exynos_cal_asv);
+
+               /* Treat negative calculated ASV as 0; expected and OK. */
+               if (exynos_cal_asv < 0)
                        exynos_cal_asv = 0;
-               }
 
                exynos_result_of_asv = exynos_cal_asv;
                pr_info("EXYNOS5250: ORIG: %d MOD: %d RESULT: %d\n",