dm crypt: fix missing error code return from crypt_ctr error path
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Fri, 17 Apr 2015 02:00:50 +0000 (22:00 -0400)
committerMike Snitzer <snitzer@redhat.com>
Fri, 17 Apr 2015 02:00:50 +0000 (22:00 -0400)
Fix to return a negative error code from crypt_ctr()'s optional
parameter processing error path.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-crypt.c

index 9b5e1eb..9eeea19 100644 (file)
@@ -1816,6 +1816,7 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv)
                if (ret)
                        goto bad;
 
+               ret = -EINVAL;
                while (opt_params--) {
                        opt_string = dm_shift_arg(&as);
                        if (!opt_string) {