mlxsw: spectrum: Add missing DCB rollback in error path
authorIdo Schimmel <idosch@mellanox.com>
Thu, 4 Aug 2016 14:36:22 +0000 (17:36 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Aug 2016 19:57:27 +0000 (12:57 -0700)
We correctly execute mlxsw_sp_port_dcb_fini() when port is removed, but
I missed its rollback in the error path of port creation, so add it.

Fixes: f00817df2b42 ("mlxsw: spectrum: Introduce support for Data Center Bridging (DCB)")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum.c

index c3e6150..e1b8f62 100644 (file)
@@ -2220,6 +2220,7 @@ err_port_vlan_init:
 err_core_port_init:
        unregister_netdev(dev);
 err_register_netdev:
+       mlxsw_sp_port_dcb_fini(mlxsw_sp_port);
 err_port_dcb_init:
 err_port_ets_init:
 err_port_buffers_init: