irda: precedence bug in irlmp_seq_hb_idx()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 19 Oct 2015 10:16:49 +0000 (13:16 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Oct 2015 14:48:26 +0000 (07:48 -0700)
This is decrementing the pointer, instead of the value stored in the
pointer.  KASan detects it as an out of bounds reference.

Reported-by: "Berry Cheng 程君(成淼)" <chengmiao.cj@alibaba-inc.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/irda/irlmp.c

index a26c401..4396459 100644 (file)
@@ -1839,7 +1839,7 @@ static void *irlmp_seq_hb_idx(struct irlmp_iter_state *iter, loff_t *off)
        for (element = hashbin_get_first(iter->hashbin);
             element != NULL;
             element = hashbin_get_next(iter->hashbin)) {
-               if (!off || *off-- == 0) {
+               if (!off || (*off)-- == 0) {
                        /* NB: hashbin left locked */
                        return element;
                }