NVMe: Fix a signedness bug in nvme_trans_modesel_get_mp
authorVishal Verma <vishal.l.verma@linux.intel.com>
Mon, 13 May 2013 20:55:18 +0000 (14:55 -0600)
committerMatthew Wilcox <matthew.r.wilcox@intel.com>
Fri, 17 May 2013 13:10:38 +0000 (09:10 -0400)
nvme_trans_modesel_get_mp() was defined with a unsigned return
type, but can return signed values.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vishal Verma <vishal.l.verma@linux.intel.com>
Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
drivers/block/nvme-scsi.c

index 64bde68..102de2f 100644 (file)
@@ -1653,7 +1653,7 @@ static void nvme_trans_modesel_save_bd(struct nvme_ns *ns, u8 *parm_list,
        }
 }
 
-static u16 nvme_trans_modesel_get_mp(struct nvme_ns *ns, struct sg_io_hdr *hdr,
+static int nvme_trans_modesel_get_mp(struct nvme_ns *ns, struct sg_io_hdr *hdr,
                                        u8 *mode_page, u8 page_code)
 {
        int res = SNTI_TRANSLATION_SUCCESS;