spi: bcm-qspi: Fix error return code in bcm_qspi_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 16 Sep 2016 14:00:19 +0000 (14:00 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 16 Sep 2016 16:23:11 +0000 (17:23 +0100)
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: fa236a7ef240 ("spi: bcm-qspi: Add Broadcom MSPI driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-bcm-qspi.c

index 2caeea7..2c121ba 100644 (file)
@@ -1205,12 +1205,14 @@ int bcm_qspi_probe(struct platform_device *pdev,
 
        if (!num_ints) {
                dev_err(&pdev->dev, "no IRQs registered, cannot init driver\n");
+               ret = -EINVAL;
                goto qspi_probe_err;
        }
 
        qspi->clk = devm_clk_get(&pdev->dev, NULL);
        if (IS_ERR(qspi->clk)) {
                dev_warn(dev, "unable to get clock\n");
+               ret = PTR_ERR(qspi->clk);
                goto qspi_probe_err;
        }