stm class: Fix master deallocation in device unregistering
authorChunyan Zhang <zhang.chunyan@linaro.org>
Mon, 15 Feb 2016 17:11:52 +0000 (19:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 20 Feb 2016 22:09:14 +0000 (14:09 -0800)
The device unregister path uses wrong master index range when it tries
to free the allocated masters, it should, as does the rest of the stm
class code, use real master IDs.

This patch fixes the device unregister path to use real master IDs to
avoid memory leaks after unloading the stm driver.

Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
[alexander.shishkin@intel.com: re-wrote the commit message]
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/stm/core.c

index cdec240..79cca94 100644 (file)
@@ -690,7 +690,7 @@ void stm_unregister_device(struct stm_data *stm_data)
                stp_policy_unbind(stm->policy);
        mutex_unlock(&stm->policy_mutex);
 
-       for (i = 0; i < stm->sw_nmasters; i++)
+       for (i = stm->data->sw_start; i <= stm->data->sw_end; i++)
                stp_master_free(stm, i);
 
        device_unregister(&stm->dev);