virtio/9p: verify device has config space
authorMichael S. Tsirkin <mst@redhat.com>
Mon, 12 Jan 2015 14:23:37 +0000 (16:23 +0200)
committerRusty Russell <rusty@rustcorp.com.au>
Wed, 21 Jan 2015 05:58:45 +0000 (16:28 +1030)
Some devices might not implement config space access
(e.g. remoteproc used not to - before 3.9).
virtio/9p needs config space access so make it
fail gracefully if not there.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
net/9p/trans_virtio.c

index daa749c..d8e376a 100644 (file)
@@ -524,6 +524,12 @@ static int p9_virtio_probe(struct virtio_device *vdev)
        int err;
        struct virtio_chan *chan;
 
+       if (!vdev->config->get) {
+               dev_err(&vdev->dev, "%s failure: config access disabled\n",
+                       __func__);
+               return -EINVAL;
+       }
+
        chan = kmalloc(sizeof(struct virtio_chan), GFP_KERNEL);
        if (!chan) {
                pr_err("Failed to allocate virtio 9P channel\n");