ixgbevf: minor cleanups for ixgbevf_set_itr()
authorEmil Tantilov <emil.s.tantilov@intel.com>
Thu, 5 Nov 2015 00:02:21 +0000 (16:02 -0800)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 30 Dec 2015 03:16:05 +0000 (19:16 -0800)
adapter->rx_itr_setting is not a mask so check it with == instead of &
do not default to 12K interrupts in ixgbevf_set_itr()

There should be no functional effect from these changes.

Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c

index 478c0f1..3558f01 100644 (file)
@@ -1047,7 +1047,7 @@ static int ixgbevf_poll(struct napi_struct *napi, int budget)
                return budget;
        /* all work done, exit the polling mode */
        napi_complete_done(napi, work_done);
-       if (adapter->rx_itr_setting & 1)
+       if (adapter->rx_itr_setting == 1)
                ixgbevf_set_itr(q_vector);
        if (!test_bit(__IXGBEVF_DOWN, &adapter->state) &&
            !test_bit(__IXGBEVF_REMOVING, &adapter->state))
@@ -1250,9 +1250,10 @@ static void ixgbevf_set_itr(struct ixgbevf_q_vector *q_vector)
                new_itr = IXGBE_20K_ITR;
                break;
        case bulk_latency:
-       default:
                new_itr = IXGBE_12K_ITR;
                break;
+       default:
+               break;
        }
 
        if (new_itr != q_vector->itr) {