pch_gbe: Use PCH_GBE_PHY_REGS_LEN instead of 32
authorDarren Hart <dvhart@linux.intel.com>
Sat, 18 May 2013 21:45:55 +0000 (14:45 -0700)
committerDarren Hart <dvhart@linux.intel.com>
Thu, 25 Jul 2013 04:29:36 +0000 (21:29 -0700)
Avoid using magic numbers when we have perfectly good defines just lying
around.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Peter Waskiewicz <peter.p.waskiewicz.jr@intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: netdev@vger.kernel.org
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c

index ab1039a..749ddd9 100644 (file)
@@ -682,7 +682,7 @@ static int pch_gbe_init_phy(struct pch_gbe_adapter *adapter)
        }
        adapter->hw.phy.addr = adapter->mii.phy_id;
        netdev_dbg(netdev, "phy_addr = %d\n", adapter->mii.phy_id);
-       if (addr == 32)
+       if (addr == PCH_GBE_PHY_REGS_LEN)
                return -EAGAIN;
        /* Selected the phy and isolate the rest */
        for (addr = 0; addr < PCH_GBE_PHY_REGS_LEN; addr++) {