amd-xgbe-phy: Checkpatch fixes
authorLendacky, Thomas <Thomas.Lendacky@amd.com>
Fri, 16 Jan 2015 18:46:29 +0000 (12:46 -0600)
committerDavid S. Miller <davem@davemloft.net>
Sat, 17 Jan 2015 03:24:19 +0000 (22:24 -0500)
This set of patches resolves some checks reported by the checkpatch
tool.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/amd-xgbe-phy.c

index 903dc3d..b65a0a8 100644 (file)
@@ -74,6 +74,7 @@
 #include <linux/of_platform.h>
 #include <linux/of_device.h>
 #include <linux/uaccess.h>
+#include <linux/bitops.h>
 
 MODULE_AUTHOR("Tom Lendacky <thomas.lendacky@amd.com>");
 MODULE_LICENSE("Dual BSD/GPL");
@@ -90,9 +91,9 @@ MODULE_DESCRIPTION("AMD 10GbE (amd-xgbe) PHY driver");
 #define XGBE_AN_PG_RCV                 0x04
 
 #define XNP_MCF_NULL_MESSAGE           0x001
-#define XNP_ACK_PROCESSED              (1 << 12)
-#define XNP_MP_FORMATTED               (1 << 13)
-#define XNP_NP_EXCHANGE                        (1 << 15)
+#define XNP_ACK_PROCESSED              BIT(12)
+#define XNP_MP_FORMATTED               BIT(13)
+#define XNP_NP_EXCHANGE                        BIT(15)
 
 #define XGBE_PHY_RATECHANGE_COUNT      500