CHROMIUM: Input: atmel_mxt_ts - warn if sysfs could not be created
authorDaniel Kurtz <djkurtz@chromium.org>
Tue, 24 Apr 2012 04:42:44 +0000 (12:42 +0800)
committerGrant Grundler <grundler@google.com>
Thu, 24 May 2012 22:12:09 +0000 (15:12 -0700)
If sysfs entry creation fails, the driver is still usable, so don't
just abort probe.  Just warn and continue.

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
BUG=chrome-os-partner:8733
TEST=builds clean

Change-Id: I67073b9ee773379395f8f9bbea3cd0163d7066ca
Reviewed-on: https://gerrit.chromium.org/gerrit/20846
Commit-Ready: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
Tested-by: Daniel Kurtz <djkurtz@chromium.org>
drivers/input/touchscreen/atmel_mxt_ts.c

index b16968f..08d080a 100644 (file)
@@ -1283,13 +1283,10 @@ static int __devinit mxt_probe(struct i2c_client *client,
 
        error = sysfs_create_group(&client->dev.kobj, &mxt_attr_group);
        if (error)
-               goto err_unregister_device;
+               dev_warn(&client->dev, "error creating sysfs entries.\n");
 
        return 0;
 
-err_unregister_device:
-       input_unregister_device(input_dev);
-       input_dev = NULL;
 err_free_irq:
        free_irq(client->irq, data);
 err_free_object: