NTB: ntb_netdev not covering all receive errors
authorDave Jiang <dave.jiang@intel.com>
Mon, 13 Jul 2015 12:07:10 +0000 (08:07 -0400)
committerJon Mason <jdmason@kudzu.us>
Sun, 9 Aug 2015 20:32:21 +0000 (16:32 -0400)
ntb_netdev is allowing the link to come up even when -ENOMEM is returned
from ntb_transport_rx_enqueue.  Fix to cover all possible errors.

Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
drivers/net/ntb_netdev.c

index 5f1ee7c..d8757bf 100644 (file)
@@ -191,7 +191,7 @@ static int ntb_netdev_open(struct net_device *ndev)
 
                rc = ntb_transport_rx_enqueue(dev->qp, skb, skb->data,
                                              ndev->mtu + ETH_HLEN);
-               if (rc == -EINVAL) {
+               if (rc) {
                        dev_kfree_skb(skb);
                        goto err;
                }