hsi: fix double kfree
authorGeliang Tang <geliangtang@163.com>
Thu, 1 Oct 2015 14:35:21 +0000 (22:35 +0800)
committerSebastian Reichel <sre@kernel.org>
Wed, 14 Oct 2015 11:22:00 +0000 (13:22 +0200)
When device_register() fails, kfree() is called in hsi_client_release(),
hence there is no need to call kfree in err3 again.

Fixes: a2aa24734d9db ("HSI: Add common DT binding for HSI client devices")
Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/hsi/hsi.c

index fe93712..35d631e 100644 (file)
@@ -300,7 +300,6 @@ static void hsi_add_client_from_dt(struct hsi_port *port,
        if (device_register(&cl->device) < 0) {
                pr_err("hsi: failed to register client: %s\n", name);
                put_device(&cl->device);
-               goto err3;
        }
 
        return;