x86/microcode: Propagate save_microcode_in_initrd() retval
authorBorislav Petkov <bp@suse.de>
Mon, 6 Jun 2016 15:10:46 +0000 (17:10 +0200)
committerIngo Molnar <mingo@kernel.org>
Wed, 8 Jun 2016 09:04:20 +0000 (11:04 +0200)
Will be used in a later patch. No functionality change.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1465225850-7352-6-git-send-email-bp@alien8.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/cpu/microcode/core.c
arch/x86/kernel/cpu/microcode/intel.c

index 12823b6..9ae7fca 100644 (file)
@@ -182,17 +182,17 @@ static int __init save_microcode_in_initrd(void)
        switch (c->x86_vendor) {
        case X86_VENDOR_INTEL:
                if (c->x86 >= 6)
-                       save_microcode_in_initrd_intel();
+                       return save_microcode_in_initrd_intel();
                break;
        case X86_VENDOR_AMD:
                if (c->x86 >= 0x10)
-                       save_microcode_in_initrd_amd();
+                       return save_microcode_in_initrd_amd();
                break;
        default:
                break;
        }
 
-       return 0;
+       return -EINVAL;
 }
 
 void reload_early_microcode(void)
index 2ad40b7..d852ca9 100644 (file)
@@ -675,8 +675,8 @@ int __init save_microcode_in_initrd_intel(void)
        ret = save_microcode(&mc_saved_data, mc_saved, count);
        if (ret)
                pr_err("Cannot save microcode patches from initrd.\n");
-
-       show_saved_mc();
+       else
+               show_saved_mc();
 
        return ret;
 }