s5p-mfc: remove V4L2_FL_LOCK_ALL_FOPS from s5p-mfc
authorJohn Sheu <sheu@chromium.org>
Fri, 8 Mar 2013 04:32:08 +0000 (20:32 -0800)
committerChromeBot <chrome-bot@google.com>
Wed, 20 Mar 2013 09:04:51 +0000 (02:04 -0700)
<UPSTREAM MERGE NOT REQUIRED>

The upstream (3.9+) s5p-mfc driver handles its own locking.

BUG=chromium-os:38376
TEST=local build, run on snow

Change-Id: I0aaff284a6b0a156f10d5dca39b5ee37f3287e9c
Signed-off-by: John Sheu <sheu@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/45095

drivers/media/video/s5p-mfc/s5p_mfc.c

index 19f4ca2..6711ec2 100644 (file)
@@ -1153,10 +1153,6 @@ static int s5p_mfc_probe(struct platform_device *pdev)
        vfd->ioctl_ops  = get_dec_v4l2_ioctl_ops();
        vfd->release    = video_device_release,
        vfd->lock       = &dev->mfc_mutex;
-       /* Locking in file operations other than ioctl should be done
-          by the driver, not the V4L2 core.
-          This driver needs auditing so that this flag can be removed. */
-       set_bit(V4L2_FL_LOCK_ALL_FOPS, &vfd->flags);
        vfd->v4l2_dev   = &dev->v4l2_dev;
        snprintf(vfd->name, sizeof(vfd->name), "%s", S5P_MFC_DEC_NAME);
        dev->vfd_dec    = vfd;
@@ -1181,8 +1177,6 @@ static int s5p_mfc_probe(struct platform_device *pdev)
        vfd->ioctl_ops  = get_enc_v4l2_ioctl_ops();
        vfd->release    = video_device_release,
        vfd->lock       = &dev->mfc_mutex;
-       /* This should not be necessary */
-       set_bit(V4L2_FL_LOCK_ALL_FOPS, &vfd->flags);
        vfd->v4l2_dev   = &dev->v4l2_dev;
        snprintf(vfd->name, sizeof(vfd->name), "%s", S5P_MFC_ENC_NAME);
        dev->vfd_enc    = vfd;