[EXT-256]
[optional for OF1.4+]
- * Duplicate instruction error
- We already have ONFBIC_DUP_INSTRUCTION.
- [EXT-260]
- [required for OF1.4+]
-
* Multipart timeout error
[EXT-264]
[required for OF1.4+]
}
if (out[type]) {
- return OFPERR_ONFBIC_DUP_INSTRUCTION;
+ return OFPERR_OFPBIC_DUP_INST;
}
out[type] = inst;
}
/* OF1.2+(3,8). Permissions error. */
OFPERR_OFPBIC_EPERM,
- /* ONF1.1+(2600). Duplicate instruction. */
- OFPERR_ONFBIC_DUP_INSTRUCTION,
+ /* ONF1.1-1.3(2600), OF1.4+(3,9). Duplicate instruction. */
+ OFPERR_OFPBIC_DUP_INST,
/* ## --------------- ## */
/* ## OFPET_BAD_MATCH ## */
0004 0008 00000000
dnl Duplicate instruction type:
-# bad OF1.1 instructions: ONFBIC_DUP_INSTRUCTION
+# bad OF1.1 instructions: OFPBIC_DUP_INST
0004 0008 00000000 0004 0008 00000000
dnl Instructions not multiple of 8 in length.
0002 0020 00000000 fedcba9876543210 ffffffffffffffff 0000000000000000
dnl Write-Metadata duplicated.
-# bad OF1.1 instructions: ONFBIC_DUP_INSTRUCTION
+# bad OF1.1 instructions: OFPBIC_DUP_INST
0002 0018 00000000 fedcba9876543210 ff00ff00ff00ff00 0002 0018 00000000 fedcba9876543210 ff00ff00ff00ff00
dnl Write-Metadata in wrong position (OpenFlow 1.1+ disregards the order
])
AT_CLEANUP
+AT_SETUP([OFPT_ERROR with type OFPBIC_DUP_INST - OF1.4])
+AT_KEYWORDS([ofp-print ofp-errors])
+AT_CHECK([ovs-ofctl ofp-print 0501001400000000000300090206ccddeeff0011], [0], [dnl
+OFPT_ERROR (OF1.4) (xid=0x0): OFPBIC_DUP_INST
+OFPT_FEATURES_REPLY (OF1.1) (xid=0xeeff0011):
+(***truncated to 8 bytes from 52445***)
+00000000 02 06 cc dd ee ff 00 11- |........ |
+])
+AT_CLEANUP
+
dnl OF1.1 had OFPBIC_UNSUP_EXP_INST as 3,5.
dnl OF1.2 broke it into OFPBIC_BAD_EXPERIMENTER as 3,5
dnl and OFPBIC_BAD_EXT_TYPE as 3,6.