netdev-dummy: Fix synchronization error in netdev_dummy_get_config().
authorBen Pfaff <blp@nicira.com>
Mon, 12 Aug 2013 19:51:47 +0000 (12:51 -0700)
committerBen Pfaff <blp@nicira.com>
Fri, 16 Aug 2013 21:04:44 +0000 (14:04 -0700)
Found by Clang.

Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Andy Zhou <azhou@nicira.com>
lib/netdev-dummy.c

index 5c31210..32b0943 100644 (file)
@@ -327,12 +327,15 @@ netdev_dummy_get_config(const struct netdev *netdev_, struct smap *args)
 {
     struct netdev_dummy *netdev = netdev_dummy_cast(netdev_);
 
+    ovs_mutex_lock(&netdev->mutex);
     if (netdev->ifindex >= 0) {
         smap_add_format(args, "ifindex", "%d", netdev->ifindex);
     }
     if (netdev->pstream) {
         smap_add(args, "pstream", pstream_get_name(netdev->pstream));
     }
+    ovs_mutex_unlock(&netdev->mutex);
+
     return 0;
 }