ovs-lib: allow non-root users to check service status
authorFlavio Leitner <fbl@redhat.com>
Thu, 27 Feb 2014 12:16:34 +0000 (09:16 -0300)
committerGurucharan Shetty <gshetty@nicira.com>
Thu, 27 Feb 2014 15:41:54 +0000 (07:41 -0800)
It tries to log the status operation, so although non-root
users can see the current status, the lack of permission
to write to the log results in an error message.

This changes to log only if the user has the permission to
write to the log file.

Signed-off-by: Flavio Leitner <fbl@redhat.com>
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
utilities/ovs-lib.in

index 029ed3b..48d0c36 100644 (file)
@@ -54,7 +54,11 @@ ovs_ctl () {
             # of ovs-ctl. It is also useful to document the o/p in ovs-ctl.log.
             display=`"${datadir}/scripts/ovs-ctl" "$@" 2>&1`
             rc=$?
-            echo "${display}" | tee -a "${logdir}/ovs-ctl.log"
+            if test -w "${logdir}/ovs-ctl.log"; then
+                 echo "${display}" | tee -a "${logdir}/ovs-ctl.log"
+            else
+                 echo "${display}"
+            fi
             return ${rc}
         ;;
         *)