datapath-windows: fix bug in NlBufCopyAtTailUninit

We should be returning value of tail before the increment
and not after.

Signed-off-by: Nithin Raju <nithin@vmware.com>
Acked-by: Ankur Sharma <ankursharma@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>

diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.c b/datapath-windows/ovsext/Netlink/NetlinkBuf.c
index ba10d83..918bddd 100644 (file)
--- a/datapath-windows/ovsext/Netlink/NetlinkBuf.c
+++ b/datapath-windows/ovsext/Netlink/NetlinkBuf.c
@@ -213,15 +213,13 @@ done:
 PCHAR
 NlBufCopyAtTailUninit(PNL_BUFFER nlBuf, UINT32 len)
 {
-    PCHAR ret = NULL;
+    PCHAR ret;
 
+    ret = nlBuf->tail;
     if ((NlBufCopyAtTail(nlBuf, NULL, len)) == FALSE) {
-        goto done;
+        ret = NULL;
     }
 
-    ret = nlBuf->tail;
-
-done:
     return ret;
 }