lib/flow: call memcmp in miniflow_equal()
authorDaniele Di Proietto <ddiproietto@vmware.com>
Tue, 27 May 2014 22:20:08 +0000 (15:20 -0700)
committerBen Pfaff <blp@nicira.com>
Tue, 27 May 2014 23:41:33 +0000 (16:41 -0700)
This commit replace a while loop in miniflow_equal() with a call to
memcmp() for performace reasons.

Signed-off-by: Daniele Di Proietto <ddiproietto@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
lib/flow.c

index 9c9adc5..da4f79b 100644 (file)
@@ -1748,11 +1748,7 @@ miniflow_equal(const struct miniflow *a, const struct miniflow *b)
     if (OVS_LIKELY(a_map == b_map)) {
         int count = miniflow_n_values(a);
 
-        while (count--) {
-            if (*ap++ != *bp++) {
-                return false;
-            }
-        }
+        return !memcmp(ap, bp, count * sizeof *ap);
     } else {
         uint64_t map;