ovn-controller: Clarify that some config changes require a restart.

Signed-off-by: Justin Pettit <jpettit@nicira.com>
Acked-by: Russell Bryant <rbryant@redhat.com>
Acked-by: Ben Pfaff <blp@nicira.com>

diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-controller.8.xml
index ca7fa43..5d4c595 100644 (file)
--- a/ovn/controller/ovn-controller.8.xml
+++ b/ovn/controller/ovn-controller.8.xml
@@ -110,5 +110,11 @@
           </p>
         </li>
       </ul>
+      <p>
+        Currently, <code>ovn-controller</code> does not support changing
+        the chassis name, integration bridge, or OVN database mid-run.
+        If these values need to change, the daemon must be restarted.
+        This behavior should be changed.
+      </p>
     </p>
 </manpage>

diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c
index 743e6bf..60ae35a 100644 (file)
--- a/ovn/controller/ovn-controller.c
+++ b/ovn/controller/ovn-controller.c
@@ -84,7 +84,10 @@ get_bridge(struct controller_ctx *ctx, const char *name)
 /* Retrieve the OVN integration bridge from the "external-ids:ovn-bridge"
  * key, the remote location from the "external-ids:ovn-remote" key, and
  * the chassis name from the "external-ids:system-id" key in the
- * Open_vSwitch table of the OVS database instance. */
+ * Open_vSwitch table of the OVS database instance.
+ *
+ * xxx ovn-controller does not support changing any of these mid-run,
+ * xxx but that should be addressed later. */
 static void
 get_core_config(struct controller_ctx *ctx)
 {
@@ -115,7 +118,6 @@ get_core_config(struct controller_ctx *ctx)
             goto try_again;
         }
 
-        /* xxx This does not support changing OVN Southbound OVSDB mid-run. */
         remote = smap_get(&cfg->external_ids, "ovn-remote");
         if (!remote) {
             VLOG_INFO("OVN OVSDB remote not specified.  Waiting...");