xml2nroff: Don't use import *.
authorRussell Bryant <russell@ovn.org>
Thu, 10 Dec 2015 19:07:26 +0000 (14:07 -0500)
committerRussell Bryant <russell@ovn.org>
Fri, 11 Dec 2015 17:01:47 +0000 (12:01 -0500)
It's generally considered bad style to do a wildcard import.  It makes
it more difficult to figure out where things come from.

Signed-off-by: Russell Bryant <russell@ovn.org>
Acked-by: Justin Pettit <jpettit@ovn.org>
build-aux/xml2nroff

index 127d4cc..2c7e9ae 100755 (executable)
@@ -20,7 +20,7 @@ import os
 import sys
 import xml.dom.minidom
 
-from build.nroff import *
+import build.nroff
 
 argv0 = sys.argv[0]
 
@@ -73,10 +73,10 @@ def manpage_to_nroff(xml_file, subst, version=None):
 .  I "\\$1"
 .  RE
 ..
-''' % (text_to_nroff(program), text_to_nroff(section),
-       text_to_nroff(title), text_to_nroff(version))
+''' % (build.nroff.text_to_nroff(program), build.nroff.text_to_nroff(section),
+       build.nroff.text_to_nroff(title), build.nroff.text_to_nroff(version))
 
-    s += block_xml_to_nroff(doc.childNodes) + "\n"
+    s += build.nroff.block_xml_to_nroff(doc.childNodes) + "\n"
 
     return s
 
@@ -117,7 +117,7 @@ if __name__ == "__main__":
 
     try:
         s = manpage_to_nroff(args[0], subst, version)
-    except error.Error, e:
+    except build.nroff.error.Error, e:
         sys.stderr.write("%s: %s\n" % (argv0, e.msg))
         sys.exit(1)
     for line in s.splitlines():