dpif-netdev: Fix memory leak in dpif_netdev_flow_put()
authorRyan Wilson <wryan@nicira.com>
Wed, 25 Jun 2014 20:05:17 +0000 (13:05 -0700)
committerBen Pfaff <blp@nicira.com>
Wed, 25 Jun 2014 20:26:53 +0000 (13:26 -0700)
miniflow_destroy() needs to be called after using miniflow_init().
Otherwise, if the miniflow mallocs data, then a memory leak may
occur.

Found by inspection.

Signed-off-by: Ryan Wilson <wryan@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
lib/dpif-netdev.c

index bbdb169..9edbe4c 100644 (file)
@@ -1339,6 +1339,7 @@ dpif_netdev_flow_put(struct dpif *dpif, const struct dpif_flow_put *put)
         }
     }
     ovs_mutex_unlock(&dp->flow_mutex);
+    miniflow_destroy(&miniflow);
 
     return error;
 }